fix: environment evaluation skip segments #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
reviewed
Oct 30, 2025
khvn26
reviewed
Oct 30, 2025
| private async getEnvironmentFlagsFromDocument(): Promise<Flags> { | ||
| const environment = await this.getEnvironment(); | ||
| const context = getEvaluationContext(environment); | ||
| const context = getEvaluationContext(environment, undefined, undefined, true); |
There was a problem hiding this comment.
nit: Can we use named arguments here?
khvn26
approved these changes
Oct 30, 2025
khvn26
reviewed
Oct 30, 2025
| } | ||
|
|
||
| // Feature types | ||
| export interface CustomFeatureMetadata extends FeatureMetadata { |
There was a problem hiding this comment.
Not quite enjoying the Custom prefix here
Suggested change
| export interface CustomFeatureMetadata extends FeatureMetadata { | |
| export interface SDKFeatureMetadata extends FeatureMetadata { |
khvn26
requested changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
getEnvironmentFlagsFromDocument